Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version on master branch #589

Closed
woop opened this issue Mar 29, 2020 · 2 comments
Closed

Fix version on master branch #589

woop opened this issue Mar 29, 2020 · 2 comments
Labels
kind/bug kind/housekeeping

Comments

@woop
Copy link
Member

woop commented Mar 29, 2020 •
edited
Loading

Expected Behavior

The master branch version should be pointed at 0.5-SNAPSHOT

Current Behavior

The master branch version is set as 0.4.2-SNAPSHOT

https://github.com/gojek/feast/blob/master/pom.xml#L39

Possible Solution

  • Short term: Just update it. Also update any other version occurrences in code
  • Long term: Consider updating the code standards workflow to prevent old versions from being reused on the master branch.
@ches
Copy link
Member

ches commented Apr 2, 2020

Also relates to #476

@woop
Copy link
Member Author

woop commented Apr 30, 2020

I believe this is done.

@woop woop closed this as completed Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug kind/housekeeping
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ches @woop