-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Compose setup is broken on master #652
Comments
An aside for feedback: the |
@ches I will pick this up. |
Thanks for raising this @ches.
Not sure about this. The docker images are set to the Although all of your points above are valid. We should probably have two configurations, one for developers and one for end users to quick start. I believe this was @khorshuheng's intention originally. |
@ches we can probably solve this through multiple PRs. I tested the following changes #661 locally and it's working for me (I only tested Redis, not BQ). I much prefer using host based networking so that we don't have to deal with private networks. I also think we should be removing all of the custom infra from our tests and using the docker compose setup for our test suite (unless we need K8s based tests). Probably a logical next step is to break the docker compose files into two. One for development and testing (using master branch) and one that is pinned to a specific version and used as part of the quickstart. |
Anyway, I have reverted my networking changes in the PR. I kept the typo fixes. @khorshuheng can you take over from here? |
Expected Behavior
Following https://docs.feast.dev/installation/docker-compose works successfully.
Current Behavior
Spring configurations fail to wire, e.g.
Steps to reproduce
Check out Feast master, and:
Specifications
Possible Solution
This has probably stemmed from the recent configuration refactor merge from #611, like
StoreConfiguration
being removed and application YAML configs underinfra/docker-compose
being stale now.Those config file fragments would need to be updated. It might be a good idea to set image tags for released Feast versions in the
.env.sample
so that user installation experience following the docs isn't susceptible to mainline development breakages, assuming configs ininfra/docker-compose
would be frozen until next release time. Alternatively/additionally to the image tags, instruct users to check out a Git tag for the Compose installation.Dev Workflow Consideration
For development I don't run the full Feast stack Docker Compose, since it isn't set up for that (rebuilding images as you change code, etc.). Rather I run the subset of
infra/docker-compose/docker-compose.yml
that is only the external service dependencies, and have the running Feast apps connect to the forwarded service ports from my host machine.I also need the patch below for that to work: there's a transposition typo in the Postgres port, and the Kafka listeners advertise
localhost:9094
instead of 9092. Both of those mean that the defaultapplication.yml
configs using the standard service ports fail to connect out of the box. Perhaps this patch can be included when fixing everything else from the big configuration refactor. I was getting ready to submit this patch when I tested the full stack and found this issue.The text was updated successfully, but these errors were encountered: