-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick fixes for type map conversion issues related to empty lists #1846
Conversation
@karlhigley: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1846 +/- ##
===========================================
- Coverage 84.45% 63.73% -20.72%
===========================================
Files 90 90
Lines 6773 6776 +3
===========================================
- Hits 5720 4319 -1401
- Misses 1053 2457 +1404
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hey! So we ended up adding a test suite for types in https://github.com/feast-dev/feast/blob/master/sdk/python/tests/integration/registration/test_universal_types.py Notably, if we add an empty list test case, there's still quite a few failures I think. Would you mind adding a test and fixing the other parts that go wrong? |
Sorry actually seems like it works fine as is. Just tested it with https://gist.github.com/adchia/b242be8d066e15a7f26852400b1d2c59 and saw that this fix indeed fixes the empty list test case when you add it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, karlhigley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
I'm going through the loop of adding tests for this in the PR which I originally opened #1703. Shall we keep discussion there? |
@judahrand Yeah, sounds good to me. Once your PR covers this case, we can close this one. |
These are the quick fixes I made in order to get list features working, as described in this comment on #1640. I'm submitting this PR in order to share the code more than to get it merged, since I know there's a larger effort to improve testing of the type map beyond these fixes.