Without feathers-rest, unnecessary errors are created

[elfey]

Steps to reproduce

Without feathers-rest configured on the server, feathers-authentication causes feathers to send back an error response of TypeError: Cannot set property 'headers' of undefined on both the client and server.

This is a link to a minimal reproducible setup.

This is a related Stack Overflow question that outlines a similar problem and what is going on.

Expected behavior

Webpage should load with desired response.

Actual behavior

Webpage receives error with undesirable response.

System configuration

Module versions (especially the part that's not working):

"feathers-authentication": "^1.0.2",

NodeJS version: 6.9.2
Operating System: macOS Sierra
Browser Version: Latest Chrome, same error on all browsers
Module Loader: NodeJS default require

[ekryski]

Thanks @mz103! In many cases we do require REST to be enabled for auth. Specifically OAuth. I think at least we should add an appropriate error if feathers-rest is not configured. I'll look into seeing if we can just make this a dependency of the OAuth1 and OAuth2 plugins as it shouldn't be required for many of the other auth mechanisms. 🍻

[wdmtech]

In many cases we do require REST to be enabled for auth. Specifically OAuth.

@ekryski Yep - this just bit me! 🙈 I created a new app with feathers-cli and all my services use websockets, so feathers-rest was never implemented.

[joakimglaving]

@ekryski is this still the case? Trying to set up GitHub OAuth2 but getting the same error as @elfey, no REST configured.

[daffl]

Yes, this is still the case. Probably won't be anymore in the upcoming version.

[joakimglaving]

Thanks for the quick reply @daffl. Do you have any idea when that version will be released?

[daffl]

Just Expressify your application for now. There is no timeframe on this at the moment.

[curioussavage]

I am using the new version I think and I still get this. Maybe a note in the documentation for the auth modules would be a good idea for now.

[daffl]

This has been addressed by the framework independent authentication in Feathers v4. Please see the migration guide for more information. Closing this issue in order to archive this repository. Related issues can be opened at the new code location in the Feathers main repository.