Update Library Dependencies and Code for Feathers 5 (Dove) (#210)

* refactor!: migrate to feathers dove (#196)

* Upgrade feathers to dove

* Add typings related for dove migration

* First iteration on tests, need more work

* Update dependencies to pre.30

* Transform hooks in a generic way for HookContext

* Add @sinclair/typebox in dev dependency (need to be removed later)

* Set node >= 14 for github CI and package.json as feathers dove supports node >= 14

* Fix tests and implementation
* use NullableId for checkUnique
* update hashPassword for reusing same context instead of new one (never transmitted)
* replace typing for hooks as @fratzinger advice

* Update to dove pre.31

* 5.0.0-pre.0

* Updating changelog

* chore: update to release versions of @feathersjs/* and feathers-hooks-common

* chore: refactor queries to use ES6 spread to fix type errors

* chore: increase strictness of eslint rules

---------

Co-authored-by: Mathieu DARTIGUES <mathieu@dartic.fr>
Co-authored-by: fratzinger <22286818+fratzinger@users.noreply.github.com>

Author: 3 people

.eslintrc

@@ -18,14 +18,14 @@
     "plugin:import/typescript"
   ],
   "rules": {
-    "semi": ["warn", "always"],
-    "@typescript-eslint/semi": ["warn", "always"],
+    "semi": ["error", "always"],
+    "@typescript-eslint/semi": ["error", "always"],
     "@typescript-eslint/strict-boolean-expressions": ["off"],
     "spaced-comment": ["off"],
     "@typescript-eslint/consistent-type-imports": ["warn", { "prefer": "type-imports" }],
     // import
-    "import/order": ["warn", { "groups": ["builtin", "external", "internal", "parent", "sibling", "index", "object", "type"] }],
-    "import/no-duplicates": ["warn"]
+    "import/order": ["error", { "groups": ["builtin", "external", "internal", "parent", "sibling", "index", "object", "type"] }],
+    "import/no-duplicates": ["error"]
   },
   "overrides": [
     {

.github/workflows/node.js.yml

@@ -10,7 +10,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [12.x, 14.x, 16.x, 18.x]
+        node-version: [14.x, 16.x, 18.x]
         # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
 
     steps:

CHANGELOG.md

@@ -2,11 +2,19 @@
 
 ## [Unreleased](https://github.com/feathersjs-ecosystem/feathers-authentication-management/tree/HEAD)
 
-[Full Changelog](https://github.com/feathersjs-ecosystem/feathers-authentication-management/compare/v4.0.2...HEAD)
+[Full Changelog](https://github.com/feathersjs-ecosystem/feathers-authentication-management/compare/v5.0.0-pre.0...HEAD)
 
 **Merged pull requests:**
 
-- chore: add tsconfig commonjs [\#193](https://github.com/feathersjs-ecosystem/feathers-authentication-management/pull/193) ([fratzinger](https://github.com/fratzinger))
+- ci: also check compile step [\#194](https://github.com/feathersjs-ecosystem/feathers-authentication-management/pull/194) ([fratzinger](https://github.com/fratzinger))
+
+## [v5.0.0-pre.0](https://github.com/feathersjs-ecosystem/feathers-authentication-management/tree/v5.0.0-pre.0) (2022-10-13)
+
+[Full Changelog](https://github.com/feathersjs-ecosystem/feathers-authentication-management/compare/v4.0.2...v5.0.0-pre.0)
+
+**Closed issues:**
+
+- Error when using with typescript app [\#192](https://github.com/feathersjs-ecosystem/feathers-authentication-management/issues/192)
 
 ## [v4.0.2](https://github.com/feathersjs-ecosystem/feathers-authentication-management/tree/v4.0.2) (2022-09-30)
 
@@ -16,6 +24,10 @@
 
 - SyntaxError: Cannot use import statement outside a module [\#191](https://github.com/feathersjs-ecosystem/feathers-authentication-management/issues/191)
 
+**Merged pull requests:**
+
+- chore: add tsconfig commonjs [\#193](https://github.com/feathersjs-ecosystem/feathers-authentication-management/pull/193) ([fratzinger](https://github.com/fratzinger))
+
 ## [v4.0.1](https://github.com/feathersjs-ecosystem/feathers-authentication-management/tree/v4.0.1) (2022-09-22)
 
 [Full Changelog](https://github.com/feathersjs-ecosystem/feathers-authentication-management/compare/v4.0.0...v4.0.1)

examples/js/package.json

@@ -37,19 +37,19 @@
     "ignore": []
   },
   "dependencies": {
-    "@feathersjs/authentication": "^4.5.15",
-    "@feathersjs/authentication-local": "^4.5.15",
-    "@feathersjs/authentication-oauth": "^4.5.15",
-    "@feathersjs/configuration": "^4.5.15",
-    "@feathersjs/errors": "^4.5.15",
-    "@feathersjs/express": "^4.5.15",
-    "@feathersjs/feathers": "^4.5.15",
-    "@feathersjs/socketio": "^4.5.15",
-    "@feathersjs/transport-commons": "^4.5.15",
+    "@feathersjs/authentication": "^5.0.0-pre.31",
+    "@feathersjs/authentication-local": "^5.0.0-pre.31",
+    "@feathersjs/authentication-oauth": "^5.0.0-pre.31",
+    "@feathersjs/configuration": "^5.0.0-pre.31",
+    "@feathersjs/errors": "^5.0.0-pre.31",
+    "@feathersjs/express": "^5.0.0-pre.31",
+    "@feathersjs/feathers": "^5.0.0-pre.31",
+    "@feathersjs/socketio": "^5.0.0-pre.31",
+    "@feathersjs/transport-commons": "^5.0.0-pre.31",
     "compression": "^1.7.4",
     "cors": "^2.8.5",
     "feathers-authentication-management": "^4.0.0",
-    "feathers-hooks-common": "^6.1.5",
+    "feathers-hooks-common": "^7.0.0-pre.1",
     "feathers-mailer": "^3.1.0",
     "feathers-sequelize": "^6.3.4",
     "helmet": "^6.0.0",