Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should other adapters rely on this or Sequelize? #14

Closed
daffl opened this issue Nov 11, 2015 · 4 comments
Closed

Should other adapters rely on this or Sequelize? #14

daffl opened this issue Nov 11, 2015 · 4 comments

Comments

@daffl
Copy link
Member

daffl commented Nov 11, 2015

I just had another look at Sequelize and it looks a lot like our service interface and support things like $in, $gt etc out of the box already. I am wondering if the other *SQL adapters (feathers-mysql, feathers-pg and feathers-sqlite) should use that instead?

@ekryski
Copy link
Member

ekryski commented Nov 13, 2015

Hmmm. I dunno. This is starting to feel like the difference between feathers-mongodb and feathers-mongoose. Sequalize allows you to define models and schemas and stuff (which probably makes more sense for a relational db). I'm open to supporting both as long as it isn't too much work.

@daffl
Copy link
Member Author

daffl commented Nov 13, 2015

I think we can totally support both. The main question is what the official adapters should use. Currently I'm leaning towards Sequelize mainly because of the higher adoption and it lines up better with our service concept.

@ekryski
Copy link
Member

ekryski commented Nov 14, 2015

ok let's get the first cut of these other db adapters out then we can revisit sequelize for the 2.0 release possibly.

@daffl
Copy link
Member Author

daffl commented Nov 23, 2015

Closing this since we'll do it ORM instead of Database specific.

@daffl daffl closed this as completed Nov 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants