Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is there an init method in this service? #183

Closed
bertho-zero opened this issue Jan 2, 2019 · 4 comments · Fixed by #223
Closed

Why is there an init method in this service? #183

bertho-zero opened this issue Jan 2, 2019 · 4 comments · Fixed by #223
Labels
enhancement

Comments

@bertho-zero
Copy link
Contributor

Why is there an init method in this service? this method is not documented and uses knex before the application setup.
@daffl
Copy link
Member

daffl commented Jan 7, 2019

Dang, I should've removed that in the latest release. I don't think it is being used anywhere anymore (except for maybe the tests which can be easily changed).

@bertho-zero
Copy link
Contributor Author

Ok, init is also used in feathers-rethinkdb.

@bertho-zero
Copy link
Contributor Author

@daffl Should not this be removed with v4.3.0 ?

@daffl
Copy link
Member

daffl commented Aug 27, 2019

Oh, I forgot about this. Would you mind submitting a PR? It'll be a breaking change but it should be fine since the database adapters are versioned independently anyway.

@vonagam vonagam mentioned this issue Sep 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove init method
2 participants
@daffl @bertho-zero