Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: ability to CRUD without needing to bind as a feathers service #19

Closed
dbkaplun opened this issue Dec 1, 2015 · 3 comments
Closed

Comments

@dbkaplun
Copy link

dbkaplun commented Dec 1, 2015

Theoretically I am passing all the info needed in order for feathers-knex to CRUD with the database. There's no reason why I should have to bind to a URL in order to .create, for example.

P.S. sorry if I'm filing too many issues, feel free to close!

@daffl
Copy link
Member

daffl commented Dec 1, 2015

No problem at all, thank you for asking questions!

This seems similar to feathersjs-ecosystem/feathers-hooks#25 right? You can use the Knex adapter standalone (have a look at the tests at https://github.com/feathersjs/feathers-knex/blob/33dfb50806e5f17186e60e8c4d751d7f29c526d4/test/index.test.js) but as already mentioned in the other issue you won't get any of the hook or real-time functionality or flexible method parameters (e.g. instead of just calling service.create(data) you always have to use service.create(data, {}, function() {})).

Generally, registering a service with your app shouldn't be a big problem considering what you get from it. We probably do need an easier way than special hooks to disable public access though.

@ekryski
Copy link
Member

ekryski commented Dec 21, 2015

Ya I think we should create a proper issue around that. I had one open for disabling service methods but you also might want all the service methods available, just not public.

@daffl
Copy link
Member

daffl commented Mar 22, 2016

This can now be done with the disable hook.

@daffl daffl closed this as completed Mar 22, 2016
@dbkaplun dbkaplun changed the title Feature request: ability to CRUD without needing to bind as a feathers service Feature: ability to CRUD without needing to bind as a feathers service May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants