Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create method with knex plugged with mssql database returns no id. Gets General Error in feathers api #243

Closed
Oumar24sh opened this issue Feb 17, 2020 · 2 comments

Comments

@Oumar24sh
Copy link
Contributor

Oumar24sh commented Feb 17, 2020

feathers-knex\lib\index : line 245

const returning = client === "pg" || client === "oracledb" || client === "mssql"? [this.id] : [];

Added mssql as client in ternary and it worked (in bold)
please update in future release

@Oumar24sh Oumar24sh changed the title Create with knexDb plugged with mssql returns no id gets General Error Create method with knex plugged with mssql database returns no id. Gets General Error in feathers api Feb 17, 2020
@daffl
Copy link
Member

daffl commented Feb 17, 2020

You can make the change directly by clicking the edit link on https://github.com/feathersjs-ecosystem/feathers-knex/blob/master/lib/index.js and submitting a pull request. Then we can make a future release right away.

@Oumar24sh
Copy link
Contributor Author

Done 👍. Thanks for the quick reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants