-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review patch and remove many for consistency #26
Comments
Hmm I saw the original issue in feathers-sequelize. Do you have know what the issue is with pagination? We have tests for it and they are passing so it should work... |
We don't test remove and patch many with pagination enabled. Basically any method that calls another method may behave inconsistently. An example is that |
Ahhh. Ya ok that makes sense. 💩 Yes, when we converted over to this new style it did feel a bit weird but it was keeping things DRY so I just shrugged and moved on. I guess we'll need to not reuse internal methods and just deal with things directly. Damn... |
Shouldn't be too much though. Basically just pulling out the direct filtering logic from |
Ya I think so too. |
This should be fixed via #29 |
Initially brought up in feathersjs-ecosystem/feathers-sequelize#7, retrieving the records may not behave consistently and also won't work well when pagination is enabled.
The text was updated successfully, but these errors were encountered: