Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transpile fails for client builds #103

Closed
DominikTrenz opened this issue Mar 8, 2018 · 3 comments · Fixed by #110
Closed

Transpile fails for client builds #103

DominikTrenz opened this issue Mar 8, 2018 · 3 comments · Fixed by #110
Labels

Comments

@DominikTrenz
Copy link

DominikTrenz commented Mar 8, 2018

This module requires:

"@feathersjs/commons": "^1.4.0",
"@feathersjs/feathers": "^3.1.1",

Those are untranspiled versions, which will break builds that require to run in non es6 browsers
(edge, ie11).
Please manually transpile the dependencies or require the "@feathersjs/client" version of those modules.

Related:
feathersjs/feathers#608

@daffl
Copy link
Member

daffl commented Mar 8, 2018

Same issue as #101

@daffl
Copy link
Member

daffl commented Mar 8, 2018

How to set up Feathers to properly work for client builds outside created-react-app is outlined in https://docs.feathersjs.com/api/client.html#module-loaders

@DominikTrenz
Copy link
Author

DominikTrenz commented Mar 13, 2018

Webpack config isn't accessible for Angular CLI users. It is accessible using ng eject, but then the user looses all Angular CLI features, which is not recommended.

Can't we just include transpiled code in the module, which is the recommended way? Maybe in a separate module like the '@feathersjs/client' module?

@daffl daffl added the bug label Apr 25, 2018
This was referenced May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants