Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lodash.values #587

Closed
marshallswain opened this issue Mar 16, 2021 · 4 comments
Closed

Remove lodash.values #587

marshallswain opened this issue Mar 16, 2021 · 4 comments

Comments

@marshallswain
Copy link
Member

Screen Shot 2021-03-16 at 10 30 28 AM

@J3m5
Copy link
Contributor

J3m5 commented Mar 16, 2021

I've started working on it and ended-up making a refactor of the getters module.
In fact, this is the only place were there was still the lodash values method.

@marshallswain
Copy link
Member Author

Awesome. Could you make these same changes in the vue-demi branch? I really need to get the documentation done. That's all that's left to publish. I was going to switch it to Nuxt, but instead am now choosing to keep what we have. Time to keep things simple with so much else going on.

Anyway, thanks for starting the PR.

@J3m5
Copy link
Contributor

J3m5 commented Mar 17, 2021

No problem, do you see anything else that need to be addressed ?

@fratzinger
Copy link
Collaborator

This is merged in master (#588) and in vue-demi (#593). It's only used in tests on both branches.
To get things cleaned up a little bit, I think this can be closed. Please reopen, if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants