Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

Possibly remove Babel from generated app #31

Closed
daffl opened this issue Feb 6, 2016 · 8 comments
Closed

Possibly remove Babel from generated app #31

daffl opened this issue Feb 6, 2016 · 8 comments

Comments

@daffl
Copy link
Member

daffl commented Feb 6, 2016

I just did some tests and I think Node 5 now pretty much supports all ES6 features that we are using in the docs and the generator except for modules (which actually isn't part of the ES6 spec anyway).

Since @marshallswain already noticed slower app startup time and higher memory consumption using Babel I am proposing to just switch the generator and all documentation examples to require imports and syntax that is supported by latest Node.

@marshallswain
Copy link
Member

👍

@daffl
Copy link
Member Author

daffl commented Feb 7, 2016

This will also fix the demo problem submitted in feathersjs/feathers#212. As long as you are using the latest Node everything should work. In older Node versions you'll just have to use ES5 (which we will mention in the docs).

@ekryski
Copy link
Member

ekryski commented Feb 7, 2016

k I'll convert this today.

@daffl
Copy link
Member Author

daffl commented Feb 8, 2016

We probably need to check process.version and throw an error if it is not Node 5 though. Or enable Babel in that case but I'm not sure if it's worth the effort.

@marshallswain
Copy link
Member

Let's just provide instructions on how they can add Babel if they need another Node version.

@sscaff1
Copy link

sscaff1 commented Mar 27, 2016

@marshallswain @daffl Were the instructions on how we can add Babel pack ever added somewhere?

@marshallswain
Copy link
Member

@sscaff1 I'm pretty sure they haven't been added, yet. I created this issue for it, yesterday: feathersjs-ecosystem/docs#105

@daffl
Copy link
Member Author

daffl commented Mar 27, 2016

We should definitely have a "Setting up guide" (that most importantly mentions to use nvm and also includes Babel) but the Babel setup would really just be a copy of https://babeljs.io/docs/setup (CLI or require hook). There is nothing Feathers specific that needs to be done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants