Skip to content
This repository has been archived by the owner on Mar 22, 2022. It is now read-only.

Make all hooks optional if used internally #138

Closed
3 tasks done
ekryski opened this issue Mar 29, 2016 · 2 comments
Closed
3 tasks done

Make all hooks optional if used internally #138

ekryski opened this issue Mar 29, 2016 · 2 comments
Labels
Milestone

Comments

@ekryski
Copy link
Member

ekryski commented Mar 29, 2016

Most of the hooks already do this. These ones need to be updated:

  • query with current user
  • associate with current user
  • hash password
@ekryski ekryski added the Task label Mar 29, 2016
@ekryski ekryski added this to the 0.7 milestone Mar 29, 2016
@daffl
Copy link
Member

daffl commented Mar 29, 2016

It is possible for a user to overwrite params.provider so you run the risk of exposing unsecured methods to the outside world. Although unlikely we might want to investigate using Object.defineProperty so that it doesn't happen accidentally.

@ekryski
Copy link
Member Author

ekryski commented Mar 29, 2016

Sure. Let's create another issue for that though because that touches all the hooks and I don't want to block shipping in this in order to prevent someone from possibly screwing up their hooks.

@ekryski ekryski mentioned this issue Mar 30, 2016
17 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants