This repository was archived by the owner on Mar 23, 2023. It is now read-only.
Use internal methods instead of service methods directly #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now I get it. 🎉 |
daffl
force-pushed
the
internal-methods
branch
from
52d089c to
8723fda
Compare
daffl
added a commit
that referenced
this pull request
Jan 30, 2016
Use internal methods instead of service methods directly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for feathersjs/feathers#218. Basically, if an adapter uses its own service methods internally (like doing a
getafter removing an item) they can't be the original service methods (likeget,create,findetc.) directly since those can be modified by Feathers with mixins and hooks and we do not want those to run in that case. The solution is to provide internal_patch,_create,_findetc. methods that can be used instead.