fix: Correctly read the oauth strategy config (#1349)

feathersjs · May 14, 2019 · 9abf314 · 9abf314
1 parent dd519f6
commit 9abf314
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/packages/authentication-oauth/src/strategy.ts b/packages/authentication-oauth/src/strategy.ts
@@ -16,13 +16,14 @@ export interface OAuthProfile {
 
 export class OAuthStrategy extends AuthenticationBaseStrategy {
   get configuration () {
-    const { entity, service, entityId } = this.authentication.configuration;
+    const { entity, service, entityId, oauth } = this.authentication.configuration;
+    const config = oauth[this.name];
 
     return {
       entity,
       service,
       entityId,
-      ...super.configuration
+      ...config
     };
   }
 

diff --git a/packages/authentication-oauth/test/strategy.test.ts b/packages/authentication-oauth/test/strategy.test.ts
@@ -12,6 +12,12 @@ describe('@feathersjs/authentication-oauth/strategy', () => {
     assert.ok(strategy.configuration.entity);
   });
 
+  it('reads configuration from the oauth key', () => {
+    const testConfigValue = Math.random()
+    app.get('authentication').oauth.test.hello = testConfigValue
+    assert.strictEqual(strategy.configuration.hello, testConfigValue)
+  });
+
   it('getRedirect', async () => {
     app.get('authentication').oauth.redirect = '/home';