fix(chore): Properly configure and run code linter (#1092)

* Properly configure and run code linter

* Move coverage exclude patterns to nyc configuration

* Do not delete exclude patterns from CodeClimate

.codeclimate.yml

@@ -35,8 +35,8 @@ plugins:
     enabled: true
     config:
       count_threshold: 3
-exclude_patterns:
-  - "**/test/*"
-  - "**/dist/*"
-  - "**/*.dist.js"
-  - "**/templates/*"
+exclude_patterns:	
+  - "**/test/*"	
+  - "**/dist/*"	
+  - "**/*.dist.js"	
+  - "**/templates/*"

.nycrc

@@ -6,6 +6,12 @@
       "mocha"
     ]
   },
+  "exclude": [
+    "**/test/*",
+    "**/dist/*",
+    "**/*.dist.js",
+    "**/templates/*"
+  ],
   "print": "detail",
   "reporter": [
     "html",

package.json

@@ -21,7 +21,7 @@
   "scripts": {
     "install": "lerna bootstrap",
     "publish": "lerna publish",
-    "lint": "semistandard packages/**/*.js --fix",
+    "lint": "semistandard \"packages/**/lib/**/*.js\" \"packages/**/test/**/*.js\" --fix",
     "test": "npm run lint && nyc lerna run test",
     "test:client": "grunt"
   },

packages/authentication-jwt/lib/verifier.js

@@ -30,10 +30,10 @@ class JWTVerifier {
       const newPayload = { [`${this.options.entity}Id`]: id };
       return done(null, entity, newPayload);
     })
-    .catch(error => {
-      debug(`Error populating ${this.options.entity} with id ${id}`, error);
-      return done(error);
-    });
+      .catch(error => {
+        debug(`Error populating ${this.options.entity} with id ${id}`, error);
+        return done(error);
+      });
   }
 }
 

packages/authentication-jwt/test/index.test.js

@@ -289,8 +289,8 @@ describe('@feathersjs/authentication-jwt', () => {
         app = expressify(feathers());
         app.use('/users', memory());
         app.configure(authentication({
-          secret: sinon.spy(function(request, token, done) {
-              done(null, 'supersecret');
+          secret: sinon.spy(function (request, token, done) {
+            done(null, 'supersecret');
           }),
           cookie: {
             enabled: true,
@@ -346,14 +346,12 @@ describe('@feathersjs/authentication-jwt', () => {
       });
 
       describe('passport strategy options', () => {
-        let authOptions;
         let args;
 
         beforeEach(() => {
           sinon.spy(passportJWT, 'Strategy');
           app.configure(jwt({ custom: true }));
           app.setup();
-          authOptions = app.get('authentication');
           args = passportJWT.Strategy.getCall(0).args[0];
         });
 

packages/client/test/fixture.js

@@ -1,4 +1,3 @@
-const path = require('path');
 const feathers = require('@feathersjs/feathers');
 const express = require('@feathersjs/express');
 const rest = require('@feathersjs/express/rest');

packages/express/test/rest/index.test.js

@@ -213,7 +213,7 @@ describe('@feathersjs/express/rest provider', () => {
           query: {},
           provider: 'rest'
         };
-        
+
         app.use('/hook-error', {
           get () {
             return Promise.reject(new Error('I blew up'));