finally should be optional #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
|
Awesome, great news. Tiny stuff, but I'm proud to be "contributing" LOL Will this be in v3 or only in v4? |
|
This will be only for v4. The typings (and some functionality) changed significantly enough that there may be some work involved in migrating. You can add this to DefinitelyTyped as well if you'd like. |
bitflower
added a commit
to bitflower/DefinitelyTyped
that referenced
this pull request
May 16, 2019
This was already merged in the types for Feathers v4 but needed here for v3 too: feathersjs/feathers#1350
16 tasks
|
Done ;-) |
sandersn
pushed a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
May 16, 2019
This was already merged in the types for Feathers v4 but needed here for v3 too: feathersjs/feathers#1350
iRON5
pushed a commit
to iRON5/DefinitelyTyped
that referenced
this pull request
Aug 13, 2019
This was already merged in the types for Feathers v4 but needed here for v3 too: feathersjs/feathers#1350
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(If you have not already please refer to the contributing guideline as described
here)
If so, please mention them to keep the conversations linked together.
Other Information
If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.
Your PR will be reviewed by a core team member and they will work with you to get your changes merged in a timely manner. If merged your PR will automatically be added to the changelog in the next release.
If your changes involve documentation updates please mention that and link the appropriate PR in feathers-docs.
Thanks for contributing to Feathers! ❤️