fix: Make oAuth paths more consistent and improve authentication client #1377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the oAuth callback paths consistent. It uses the redirects discussed in simov/grant#116 to make things more straightforward and backwards compatible. Also changes the base path to
/oauth
as previously discussed with @KidkArolis (it can be made backwards compatible by settingauthentication.oauth.defaults.path
to/auth
).The relevant oAuth paths now are:
http(s)://<host>/oauth/<provider>
to initiate the oAuth flowhttp(s)://<host>/oauth/<provider>/callback
as the callback path that should be set in the oAuth application settingshttp(s)://<host>/oauth/<provider>/authenticate
as the internal redirect