fix: Improve transport-commons types #1396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalise types of
PublishMixin
,ServiceAddons
andApplication
forpublish
/registerPublish
:string
orALL_EVENTS
symbol.callback
is nowpublisher
in argument and variable naming.this
.* - before a promise was not present in types and not mentioned in documentation, but based on this line it is possible currently to return a promise. We can remove this feature from types and remove
Promise.resolve
from that line if this should not be supported.Plus small performance improving in publishing: no point in creating array, using
_.get
and then.find
withtypeof
when simpleor
condition will do (ideally publisher should be cached).