fix: @feathersjs/express: replace reduce
with map
#1429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easier to read and faster 4 times: 500,000 vs 2,000,000 ops/sec.
Also small difference (fix): before if you
activateHooks()
some method with a nonstandard argument resulted express args getter will throw an error, now it returns valid array withundefined
for unknown arguments. (Vanilla feathers supports nonstandard arguments, but there is no test for such case.)Also
makeArguments
anddefaultMakeArguments
can be safely removed before major release, since they have been replaced with new system and not used anywhere. If for some backward compatibility reason you want to keep them, we can replace their internals with same one liner: