Make sure event hookups happens after method normalization #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daffl
changed the title
daffl
force-pushed
the
event-mixin-order
branch
from
5387fce to
7631197
Compare
daffl
added a commit
that referenced
this pull request
Oct 25, 2015
Make sure event hookups happens after method normalization
This was referenced Nov 7, 2015
daffl
added a commit
that referenced
this pull request
Nov 29, 2015
daffl
pushed a commit
that referenced
this pull request
Aug 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes sure that event punching happens after methods normalization. The issue before was that you couldn't call methods on the server without a callback (which isn't necessary).
Closes #150