Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add info to express error handler logger type #1557

Merged
merged 2 commits into from
Sep 16, 2019

Conversation

vonagam
Copy link
Member

@vonagam vonagam commented Sep 12, 2019

If provided a logger should have info property, which is used here.

Instead of void | null, just void for return type of logging functions.

msg is not a string, but any since it is used to log errors (as shown in link above) and they might not be a string.

error property is required now, if you don't want to log stuff, just do not provide logger since it is optional already.

@daffl daffl merged commit 3e1d26c into feathersjs:master Sep 16, 2019
@vonagam vonagam deleted the fix-express-error-handler-type branch September 16, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants