feat(authentication): Add setup method for auth strategies #1611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
setup
method toAuthenticationStrategy
by analogy with service setup. More convenient alternative tosetAuthentication
/setApplication
/setName
and removes the need for getters, since it ensures that all services are already registered by the time of a call.For example, right now every time you get
entityService
in a strategy you call:AuthenticationBaseStrategy.configuration
AuthenticationBase.configuration
Object.assign
andapp.get
app.service
All of those calls can be done once in
setup
method instead doing them every time.Also fixed small inconsistencies in
app.setup
:Moved this line up since otherwise a service registered in other service setup call will not get setup call.
Moved those lines down so that setup call for a dynamically registered service happens after the service is registered just like for a usual service.