Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TypeScript HookMap and HooksObject interfaces generic. #1815

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

JorgenVatle
Copy link
Contributor

Made the HookMap and HooksObject interfaces generic. Beyond adding options for one to specify types for the associated HookContext, this helps a lot with the reusability of these interfaces.

@JorgenVatle JorgenVatle marked this pull request as ready for review February 18, 2020 16:21
@daffl daffl merged commit d10145d into feathersjs:master Feb 25, 2020
@daffl
Copy link
Member

daffl commented Feb 25, 2020

Makes sense, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants