fix: remove default from queryProperty schemas
#2646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR prevents the `default` JSON Schema keyword from being copied into the query sub-schemas like `$gt`. I looked through other potential conflicts in the schema [here](https://json-schema.org/draft/2020-12/json-schema-validation.html) and there doesn’t seem to be another potential conflict.
daffl
force-pushed
the
dove-schema-query-default
branch
from
dd2bdad to
4514d34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the
defaultJSON Schema keyword from being copied into the query sub-schemas like$gt. I looked through the schema here and there doesn’t seem to be another potential conflict.