-
-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FeatherJS Apple SSO sign in issue #3482
Comments
@daffl, anything on this please? |
I don't think the service currently handles POST callbacks. It may have to be split into two separate services for this to work. |
I have a potential fix in #3497 but it might have to be tested. |
Released in v5.0.27 |
A further enhancement to fix the redirection error post the authentication, was done in version v5.0.28. Thanks @daffl <3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue Description
I need to enable Apple SSO for my feathers.js app, so that user can log in using their Apple IDs.
I am following https://gist.github.com/rxb/e596c66b03e3262f26d9ede5d7dbab81 article for enabling Apple SSO in my application.
Following is how my configurations look.
Expected behavior
Users should be able to log into my app with their Apple ID while, I have the 'name' and the 'email' of the user who logged in.
Actual behavior
Now it goes to the apple ID requesting authorization and Apple after signing in, redirects to the callback URL in a
POST
Callback request withCode
andid_token
in the body which should be handled by theAppleStrategy
code, but it insteads returns a 201 Created response with the response message similar to the following.The above message is displayed in the browser with a 201 status in response to Apple's Post Callback. I am not sure, which method of feathers is handling that and why is it returning that response while it should have inspected the
id_token
and extracted relevant information, for which I have implementedgetEntityData
and other methods.Important Note: If I just request the "openid" scope and not "name" and "email" and remove the
response_mode: "form_post"
, then Apple Returns a GET call which is handled by my code and it lets the user log in successfully. The problem occurs when I request "name" and "Email" and Apple sends a POST call on the callback URL. I am not sure if a POST callback is handled differently than the GET callback? If yes, can anyone please explain how a POST callback request is handled by Feathers authentication?Feel free to ask any questions. Please answer if you have come across a similar issue. Looking forward to hear back soon.
System configuration
Feathersjs 5, Apple SSO.
NodeJS version:
v18.17.1
Operating System:
Windows
The text was updated successfully, but these errors were encountered: