Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For when feathers for babel 7 ? #678

Closed
simonjoom opened this issue Sep 21, 2017 · 4 comments
Closed

For when feathers for babel 7 ? #678

simonjoom opened this issue Sep 21, 2017 · 4 comments

Comments

@simonjoom
Copy link

simonjoom commented Sep 21, 2017

I saw that feathers still use old plugin add-module-export and the code module is babel 6

When do you think you will update code to support babel7 ? (to allow common-js and tree shaking)

@daffl
Copy link
Member

daffl commented Sep 21, 2017

I was not aware that there is an official version of Babel 7.

Anyway, Feathers will be using ES6 imports natively only once it is officially enabled in all Node versions that Feathers supports. For now we are actually going back to require (see #608) to make things usable without a transpiler.

A Feathers v3 client build will be even smaller already (at about 8k min+gziped) so I don't think there is that much of a benefit from tree shaking.

@daffl daffl closed this as completed Sep 21, 2017
@simonjoom
Copy link
Author

yes it's not really about tree-shaking but compatibility with babel 7 who will become standard.
the version babel 7 beta is already out, and work for me.

@daffl
Copy link
Member

daffl commented Sep 21, 2017

We'll be removing Babel completely in the next version so there isn't really a reason to upgrade to v7.

@lock
Copy link

lock bot commented Feb 7, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants