Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBAC doesn't support Project Id as params of Registry API calls. #669

Closed
1 of 4 tasks
jainr opened this issue Sep 14, 2022 · 1 comment · Fixed by #673
Closed
1 of 4 tasks

RBAC doesn't support Project Id as params of Registry API calls. #669

jainr opened this issue Sep 14, 2022 · 1 comment · Fixed by #673
Assignees
Labels
feature New feature or request

Comments

@jainr
Copy link
Collaborator

jainr commented Sep 14, 2022

Willingness to contribute

Yes. I would be willing to contribute a fix for this bug with guidance from the Feathr community.

Feathr version

0.7.2

System information

  • OS Platform and Distribution (e.g., Linux Ubuntu 20.0):
  • Python version:
  • Spark version, if reporting runtime issue:

Describe the problem

Trying to register features with RBAC enabled and get this error.

MicrosoftTeams-image (1)

Tracking information

No response

Code to reproduce bug

feathr_client.register_features()

What component(s) does this bug affect?

  • Python Client: This is the client users use to interact with most of our API. Mostly written in Python.
  • Computation Engine: The computation engine that execute the actual feature join and generation work. Mostly in Scala and Spark.
  • Feature Registry API: The frontend API layer supports SQL, Purview(Atlas) as storage. The API layer is in Python(FAST API)
  • Feature Registry Web UI: The Web UI for feature registry. Written in React
@jainr jainr added the bug Something isn't working label Sep 14, 2022
@jainr jainr assigned jainr and Yuqing-cat and unassigned jainr Sep 14, 2022
@Yuqing-cat Yuqing-cat added feature New feature or request and removed bug Something isn't working labels Sep 14, 2022
@Yuqing-cat
Copy link
Collaborator

I would prefer to call it a new feature rather than bug.
Both project name and project id are unique in the registry.
GET API calls used to send project name as params and RBAC works at that time.

Now, all the API calls will take project id as params.
As a result, RBAC need to add a new feature to be able to

  • support both project name and project id (UUID)
  • recognize project name of a project id, which requires some change to backend registry APIs.

@Yuqing-cat Yuqing-cat changed the title [BUG] Registering features with RBAC enabled throws 403 error RBAC doesn't support Project Id as params of Registry API calls. Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants