Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] $userId was not defined in demo jupyter notebook product_recommendation_demo.ipynb #933

Closed
zliang9 opened this issue Dec 30, 2022 · 0 comments · Fixed by #1014
Closed
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@zliang9
Copy link

zliang9 commented Dec 30, 2022

Willingness to contribute

Yes. I would be willing to contribute to this for with guidance from the Feathr community.

URL(s) with the issue

In demo jupyter notebook product_recommendation_demo.ipynb in the link below:

https://github.com/feathr-ai/feathr/blob/9a98253481c6001a6a4c52b45dcd5a6eb35be391/docs/samples/azure_synapse/product_recommendation_demo.ipynb

Variable "$userId" was used in section "3. Prerequisite: Set the required permissions", however it was not defined in the code above, and not obtainable in cloud shell either.

Likely it should be "$objectId" instead.
Screen Shot 2022-12-29 at 19 39 40

Description of proposal (what needs changing)

Substitute "$userId" with "$objectId" instead, in section "3. Prerequisite: Set the required permissions", on this page https://github.com/feathr-ai/feathr/blob/9a98253481c6001a6a4c52b45dcd5a6eb35be391/docs/samples/azure_synapse/product_recommendation_demo.ipynb

@zliang9 zliang9 added the documentation Improvements or additions to documentation label Dec 30, 2022
@jainr jainr closed this as completed Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants