Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] REACT_APP_ENABLE_RBAC=false not recognized in registry service #953

Closed
1 of 4 tasks
Yuqing-cat opened this issue Jan 10, 2023 · 0 comments · Fixed by #954
Closed
1 of 4 tasks

[BUG] REACT_APP_ENABLE_RBAC=false not recognized in registry service #953

Yuqing-cat opened this issue Jan 10, 2023 · 0 comments · Fixed by #954
Assignees
Labels
bug Something isn't working

Comments

@Yuqing-cat
Copy link
Collaborator

Willingness to contribute

Yes. I can contribute a fix for this bug independently.

Feathr version

latest

System information

  • OS Platform and Distribution (e.g., Linux Ubuntu 20.0):
  • Python version:
  • Spark version, if reporting runtime issue:

Describe the problem

REACT_APP_ENABLE_RBAC variable is checked either configured or not rather than true or false.
In provision template, it's null if not true, so will not be a problem.

"[if(equals(parameters('enableRBAC'),'Yes'),json('true'),json('null'))]"

However, It might cause problem when user manually set REACT_APP_ENABLE_RBAC == false.

Tracking information

No response

Code to reproduce bug

No response

What component(s) does this bug affect?

  • Python Client: This is the client users use to interact with most of our API. Mostly written in Python.
  • Computation Engine: The computation engine that execute the actual feature join and generation work. Mostly in Scala and Spark.
  • Feature Registry API: The frontend API layer supports SQL, Purview(Atlas) as storage. The API layer is in Python(FAST API)
  • Feature Registry Web UI: The Web UI for feature registry. Written in React
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant