-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test to ensure estimators raise errors when X has duplicated column names #687
Comments
Thank you @david-cortes |
hi @solegalli and @david-cortes, Slowly dipping my toes back into feature-engine. Is the idea to create a test/check function on dataframe_checks.py and then add the check functions to the parent transformers in the fit() method? |
No, I think the idea was to add a generic test to estimator_checks to test all transformers to ensure that they inherit this functionality properly. I am not sure if it is an overkill or not. |
Ok, so as the code base stands, feature-engine transformers raise errors when there are duplicative feature names, correct? This issue is to create a test that the error is being raised when expected. |
Correct! |
Per comment in PR: #686 (review)
After the PR in the link above gets merged, there will be a general check for duplicated columns for which a test was added in
test_dataframe_checks.py
. This new error raised on duplicated column names should be tested also in the invidual transformers inestimator_checks/*
after the files gets refactored.The text was updated successfully, but these errors were encountered: