Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test to ensure estimators raise errors when X has duplicated column names #687

Open
david-cortes opened this issue Jul 25, 2023 · 5 comments

Comments

@david-cortes
Copy link
Contributor

Per comment in PR: #686 (review)

After the PR in the link above gets merged, there will be a general check for duplicated columns for which a test was added in test_dataframe_checks.py. This new error raised on duplicated column names should be tested also in the invidual transformers in estimator_checks/* after the files gets refactored.

@solegalli
Copy link
Collaborator

Thank you @david-cortes

@solegalli solegalli changed the title TODO: tests for estimators about raising errors on duplicated column names add test to ensure estimators raise errors when X has duplicated column names Jul 26, 2023
@Morgan-Sell
Copy link
Collaborator

hi @solegalli and @david-cortes,

Slowly dipping my toes back into feature-engine.

Is the idea to create a test/check function on dataframe_checks.py and then add the check functions to the parent transformers in the fit() method?

@solegalli
Copy link
Collaborator

No, I think the idea was to add a generic test to estimator_checks to test all transformers to ensure that they inherit this functionality properly. I am not sure if it is an overkill or not.

@Morgan-Sell
Copy link
Collaborator

Ok, so as the code base stands, feature-engine transformers raise errors when there are duplicative feature names, correct? This issue is to create a test that the error is being raised when expected.

@solegalli
Copy link
Collaborator

Correct!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants