Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shift-click not working on seeing_profile and tabs not displaying properly #93

Closed
JuanCab opened this issue Jun 2, 2023 · 4 comments
Closed
Assignees

Comments

@JuanCab
Copy link
Contributor

JuanCab commented Jun 2, 2023

The current version of the code from GitHub (pre-astro 5.3 patch) running on my Mac is having two problems with seeing_profile

  1. right-click is NOT properly triggering the construction of the TESS Seeing Profile (a button appears, but the seeing profile is not present).
  2. The SNR/Seeing Profile/Integrated Counts tabs DO NOT appear, instead the text appears all mashed together (See image linked from first comment below). Problem occurs whether run in JupyterLab or VSCode running Jupyter notebook extensions.

The version running on our Jupyter3 server doesn't appear to have an issue. Emily and I were able to extract the stellarphot codebase used on Jupyter3, and comparing it to the current codebase there seemed to be NO relevant differences in stellarphot.visualization.seeing_profile_functions.py in the two versions (e.g. - only differences was in __all__ list and in np.int being replaced with int in the newer code).

@JuanCab JuanCab self-assigned this Jun 2, 2023
@JuanCab
Copy link
Contributor Author

JuanCab commented Jun 2, 2023

Screenshot showing the screen on my Mac running Jupyter Lab in Brave (a Chromium based browser)

I also confirmed that the same behavior is seen in a clean install version of Google Chrome.

@JuanCab
Copy link
Contributor Author

JuanCab commented Jun 5, 2023

After a bit of exploration with an environment similar to the one on jupyer3 server and then updating libraries, I finally discovered what BROKE the tabs is updating jupyterlab to 4.0.1 (which updated jupyter_server to 2.6.0)!

I confirmed that the following conda environment, which has everything up to date EXCEPT jupyterlab does display tabs properly (although the stellar profile display still doesn't appear to work):

name: SNdev
channels:
  - conda-forge
dependencies:
  - aggdraw
  - arrow
  - astropy
  - astroquery
  - astrowidgets
  - batman-package
  - bottleneck
  - ccdproc
  - fqdn
  - gatspy
  - ginga
  - graphviz
  - ipyfilechooser
  - ipython
  - ipywidgets
  - isoduration
  - jsonpointer
  - jupyter
  - jupyterlab=3.4.5
  - matplotlib
  - numpy
  - pandas
  - photutils
  - pytest
  - python=3.11.*
  - pyyaml
  - scipy
  - sphinx-astropy
  - tox
  - uri-template
  - webcolors
prefix: ~/miniconda3/envs/SNdev

This suggests that unfortunately the tab-display problem is probably due to how one of the widget libraries (likely either astrowidgets or ipywidgets) interacts with the latest jupyterlab.

@JuanCab JuanCab changed the title shift-click not working on seeing_profile shift-click not working on seeing_profile and tabs not displaying properly Jun 5, 2023
@JuanCab
Copy link
Contributor Author

JuanCab commented Jun 15, 2023

With regards to the shift-click issue, this was due to the code trying to use an unreleased version of astrowidgets. This was fixed with pull request [#92].

The tabs not rendering properly turned out to be an issue with ipywidgets running in JupyterLab >=4. I reported this as an issue to JupyterWidgets a week ago. Looks like today Andy Maloney and Martin Renou at JupyterWidgets have figured out the issue with tabs and resolved it with JupyterLab PR #3787.

@JuanCab JuanCab closed this as completed Jun 15, 2023
@JuanCab
Copy link
Contributor Author

JuanCab commented Jul 9, 2023

Fixed in ipywidgets 8.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant