Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reminder's modal dialog stays open when fast exiting note (on emulator or slow devices) #968

Open
amczuboka opened this issue Mar 29, 2024 · 1 comment
Labels
Good first issue Easy task to work on for starters Improvements

Comments

@amczuboka
Copy link

How to reproduce:
Launch OmniNotes
Select a note from homepage
Click ‘Add reminder’
Click ‘<-’ icon quickly after
The add reminder dialog will still appear
Select a time and click ‘OK’
Reminder will not be set

Actual Behavior:
https://github.com/federicoiosue/Omni-Notes/assets/94947740/3ab33e71-ddf8-459f-b1b4-b469c58f758a

Expected Behavior:
When the note is exited after pressing 'Add reminder', either the dialog does not appear or the reminder is set even when on a different page.

Device information: Pixel_3a_API_34_extension_level_7_x86_64

App version=6.3.1
Android Studio Hedgehog | 2023.1.1 Patch 2
Build #AI-231.9392.1.2311.11330709, built on January 18, 2024
Runtime version: 17.0.7+0-17.0.7b1000.6-10550314 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.

@amczuboka amczuboka changed the title [Bug]: Reminder is not setting when the note quickly [Bug]: Reminder is not setting when the note is exited quickly Mar 29, 2024
@federicoiosue
Copy link
Owner

Nice test 😃
I believe this happens on your emulator due to performances constriction but it doesn't affect real life app usage.
Anyway this could be a good "first issue" that could be worked by ensuring that when the reminder picker dialog appears the underlying fragment is still alive and shown.

@federicoiosue federicoiosue added Improvements Good first issue Easy task to work on for starters labels Apr 3, 2024
@federicoiosue federicoiosue changed the title [Bug]: Reminder is not setting when the note is exited quickly Reminder's modal dialog stays open when fast exiting note (on emulator or slow devices) Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Easy task to work on for starters Improvements
Projects
None yet
Development

No branches or pull requests

2 participants