Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mastodon Node: make_a_follow_b incorrect failure condition? #280

Closed
steve-bate opened this issue Jul 31, 2024 · 1 comment
Closed

Mastodon Node: make_a_follow_b incorrect failure condition? #280

steve-bate opened this issue Jul 31, 2024 · 1 comment

Comments

@steve-bate
Copy link
Member

def make_a_follow_b(self, a_uri_here: str, b_uri_there: str, node_there: ActivityPubNode) -> None:
        # ...
        if b_account := next(
            (b for b in results.get("accounts", []) if b.uri == b_uri_there), None
        ):
            # ...
        raise ValueError(f'Actor URI not found: { b_uri_there }') # <---- always raises error

Should this be?

        if b_account := next(...):
            # ...
        else:
            raise ValueError(f'Actor URI not found: { b_uri_there }')
@jernst jernst added this to the FediTest 0.4 released milestone Aug 12, 2024
@jernst
Copy link
Member

jernst commented Sep 20, 2024

This is now obsolete with #349 .

@jernst jernst closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants