Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide webhook payload for triggered builds #634

Open
fedora-copr-github-bot opened this issue Nov 16, 2022 · 1 comment · May be fixed by #3467
Open

Provide webhook payload for triggered builds #634

fedora-copr-github-bot opened this issue Nov 16, 2022 · 1 comment · May be fixed by #3467
Labels
RFE Enhancement, feature requests

Comments

@fedora-copr-github-bot
Copy link
Collaborator

fedora-copr-github-bot commented Nov 16, 2022

Original issue: https://pagure.io/copr/copr/issue/634
Opened: 2019-04-03 20:14:03
Opened by: frostyx

When a build is triggered by webhook, we don't set the "build by" field nor display any information about the webhook. People then ask what and why submitted the build.

Are we able to store the webhook payload or just parse some information from it and link it in the build info page?


praiskup commented at 2019-04-04 05:22:48:

we don't set the "build by"

This probably isn't good for build scheduler ... hmm.

+1 for the hook payload backup somewhere, discussed also here https://pagure.io/copr/copr/issue/628#comment-564135


praiskup commented at 2020-06-22 10:58:28:

Btw., custom webhook content is stored in result dir on backend. The only
thing I'm not sure about is the security perspective (can webhooks contain
some private data?). If this isn't safe to make public, we have to store
the webook in Frontend "build_private" table (temporarily, since it is a
lot of data).

@praiskup
Copy link
Member

Triage time: @FrostyX wants at least basic info about the build, like "This has been submitted by webhook".
Then there's issue #304 that we could combine this with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFE Enhancement, feature requests
Projects
Status: In 2 years
2 participants