Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javacript error prevents modify settings #334

Open
sergiomb2 opened this issue Feb 15, 2021 · 10 comments
Open

javacript error prevents modify settings #334

sergiomb2 opened this issue Feb 15, 2021 · 10 comments
Assignees

Comments

@sergiomb2
Copy link

sergiomb2 commented Feb 15, 2021

https://koschei.fedoraproject.org/package/debhelper?

Uncaught TypeError: can't convert Object to string
_jQueryInterface https://apps.fedoraproject.org/global/fedora-bootstrap-1.0.3/fedora-bootstrap.js:3166
jQuery 2
_jQueryInterface https://apps.fedoraproject.org/global/fedora-bootstrap-1.0.3/fedora-bootstrap.js:3161
Collapse https://apps.fedoraproject.org/global/fedora-bootstrap-1.0.3/fedora-bootstrap.js:3212
jQuery 2

@voxik
Copy link

voxik commented Feb 17, 2021

It seems that similar error prevents expanding the changed dependency list

@mizdebsk
Copy link
Member

I am aware of this issue, but I have no idea what causes it as there were no changes on Koschei side. I suspect extarnal JavaScript bundle that is loaded from apps.fedoraproject.org changed.

@mizdebsk mizdebsk self-assigned this Feb 17, 2021
@hrnciar
Copy link

hrnciar commented Mar 5, 2021

Hello, is there any update on this?

@mizdebsk
Copy link
Member

mizdebsk commented Mar 5, 2021

I was investigating this issue, but it is unclear to me what is causing it as there were no code changes in Koschei JavaScript code. It could be that fedora-bootstrap (which JavaScript code is imported by Koschei) was changed underneath.
I intend to remove dependency on externally-loaded fedora-bootstrap and bundle all dependencies in Koschei itself, but I don't know whether that would resolve this issue.

@mizdebsk
Copy link
Member

mizdebsk commented Mar 5, 2021

I found the cause of the issue, I'm working on a fix now.

@mizdebsk
Copy link
Member

mizdebsk commented Mar 5, 2021

A hotfix has been applied in production deployment at Fedora infrastructure. A proper fix will be implemented later.

@sergiomb2
Copy link
Author

Thank you , it is working for me

@mizdebsk
Copy link
Member

mizdebsk commented Mar 5, 2021

Thank you for confirming the hotfix, but the real issue is still not fixed in Koschei, so please leave this bug open for now.

@mizdebsk mizdebsk reopened this Mar 5, 2021
@hrnciar
Copy link

hrnciar commented Mar 5, 2021

Even though you can modify settings now, I think there is another issue. I am unable to set the package to be tracked. After I submit the form it still says Tracked by Koschei False. On the other hand, manual priority has changed but it doesn't seem like it triggered the actual build. E.g. this package https://koschei.fedoraproject.org/package/python-emcee?collection=f35

@mizdebsk
Copy link
Member

mizdebsk commented Mar 5, 2021

The issue with tracked that cannot be changed was opened as a separate issue #336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants