Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyp2rpm converts all extras to runtime Requires #283

Open
hroncok opened this issue May 16, 2022 · 0 comments
Open

pyp2rpm converts all extras to runtime Requires #283

hroncok opened this issue May 16, 2022 · 0 comments

Comments

@hroncok
Copy link
Member

hroncok commented May 16, 2022

I've noticed here and here:

https://bugzilla.redhat.com/show_bug.cgi?id=2083243 fastbencode 0.0.7
https://bugzilla.redhat.com/show_bug.cgi?id=2058961 unicodedata2 14.0.0

In both cases, the extras used to build/test the package were converted to runtime requires.

fastbencode[cext] caused:

Requires:       python3dist(cython) >= 0.29

unicodedata2[testing] caused:

Requires:       python3dist(coverage)
Requires:       python3dist(pytest)
Requires:       python3dist(pytest-randomly)
Requires:       python3dist(pytest-xdist)

This is not a good idea. Those are build dependencies, not runtime dependencies. pyp2rpm cannot know if the extras are useful at runtime or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant