-
Notifications
You must be signed in to change notification settings - Fork 429
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility suggestion (aria roles) #260
Comments
Hey, I have already optimised the complete BaguetteBox for WCAG 2.0, had to adapt some things, but it works well so far, furthermore I have extended the functionality, you can not only open images in a modal, but also Youtube videos, MP4 and HTML content. A lot has been adjusted based on version 1.11.1. The plan was to create a new repository named "BaguetteBox++" because, two weeks ago, the last update was from four years ago, so I wasn’t sure if the project was still actively maintained. @feimosi let me know how to proceed here, it is not little what I have done |
Howdy,
From a recent 3rd party audit with credentialed accessibility auditors, they had the following to say:
Success criteria
4.1.2 Name, Role, Value (WCAG 2.0 A)
Native Widgets: Link Function & Role
If an anchor element () is coded to function as something other than a link, it must have the correct ARIA widget role.
The image components on this page are coded as links but functions more appropriately as buttons.
Note: When these components are activated they expose a modal.
Remediation Recommendation
Native HTML elements should always be used if possible (eg. use for button functionality).
If you must use an anchor element to function as a button, for example, add role=“button” to the element and then ensure it can be activated with the spacebar (in addition to the return/enter key)
—
For your consideration, could you also consider adding the ability to add the button role, and possible an event listener for the space button as well to trigger the modal?
Thank you!
The text was updated successfully, but these errors were encountered: