Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs with delayed-stream .maxDataSize set to Infinity #39

Open
narychen opened this issue Mar 30, 2018 · 1 comment
Open

Bugs with delayed-stream .maxDataSize set to Infinity #39

narychen opened this issue Mar 30, 2018 · 1 comment

Comments

@narychen
Copy link

nodejs/node#16706 (comment)

According to the report issue, there will be problem with this. Why .maxDataSize still set to Infinity in this repo ?

@mildsunrise
Copy link
Contributor

I think you mean:

maxDataSize: Infinity,

Reducing maxDataSize won't fix the problem, because when the limit is reached an error will be thrown.

Instead, delayed-stream should be modified to apply constant backpressure to the stream it wraps. If you have a test demonstrating nodejs/node#16706, please post it and I'll work on a fix for delayed-stream. Meanwhile, I think this issue should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants