Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0-alpha.5 Missing Dependencies #85

Closed
AgentSource opened this issue Mar 16, 2020 · 3 comments · Fixed by #89
Closed

1.0.0-alpha.5 Missing Dependencies #85

AgentSource opened this issue Mar 16, 2020 · 3 comments · Fixed by #89

Comments

@AgentSource
Copy link

AgentSource commented Mar 16, 2020

Testing out 1.0.0-alpha.5...

Current package version

  • Bull => 3.13.0
  • BullMQ => Not installed

Steps Taken

1.npm i bull-board@1.0.0-alpha.5
2. tsc -p project_src

However tsc fails and I get the error below

node_modules/bull-board/dist/index.d.ts:2:34 - error TS2307: Cannot find module 'bullmq'. 2 import { Queue as QueueMq } from 'bullmq';

node_modules/bull-board/dist/index.d.ts:3:30 - error TS2307: Cannot find module 'express-serve-static-core'.
3 declare const router: import("express-serve-static-core").Express;

Note I tested 1.0.0-alpha.4 to confirm and got the same error

Also manually installed bullmq package and error did go away however I received this new error

node_modules/bullmq/dist/interfaces/sandboxed-job.d.ts:3:57 - error TS2304: Cannot find name 'Omit'.

3 export interface SandboxedJob<T = any, R = any> extends Omit<JobJson, 'data' | 'opts' | 'progress' | 'log' | 'returnValue'> {

@vcapretz
Copy link
Contributor

Thanks for reporting it!

We have this bug now because of we need the types coming from bullmq and Bull at the same time, to be honest I’m not sure how to solve it but I will take a look ☺️

@Yurickh
Copy link
Contributor

Yurickh commented Mar 19, 2020

Omit was introduced in typescript v3.5.
Be sure to check if your version of typescript satisfies it.

I'd also recommend adding a section on the readme regarding which ts versions are supported, @vcapretz.

@HugoPoi
Copy link

HugoPoi commented Sep 21, 2020

I test the alpha.10, I'm not sure if it's intended that bullmq to be mandatory and if this is a peer dependency ?
We should put

    "bull": "^3.13.0",
    "bullmq": "^1.8.2",

in peerDependencies I think, and have a conditional require/import on them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants