-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Official API Server - Recipes submodule update #31
Comments
@SpecialAro instead of running cron, shall we expose a web-hook/api endpoint which will be triggered by the GH action whenever a new commit happens in main/develop branch of recipes repo and pulls the new commits? what do you think ? |
What I would caution is:
|
this is pretty interesting. Been looking into it and can be something to be implemented, not only for the recipes repo but also to the server repo. |
Problem
The official API Server of Ferdium (https://api.ferdium.org/) is currently running through the docker image provided by https://hub.docker.com/repository/docker/ferdium/ferdium-server.
I've checked the container and the recipes folder is not currently a git repository. Once we upgrade the recipes main branch, the server currently needs to be updated manually by:
This process is totally non-sense and automation is very much in need.
Proposed Solution
My proposal is:
.dockerignore
file, so that when we build the image the "recipes" folder is not present.dockerfile
(https://github.com/ferdium/ferdium-server/blob/main/Dockerfile) or theentrypoint.sh
(https://github.com/ferdium/ferdium-server/blob/main/docker/entrypoint.sh)entrypoint.sh
: Git pull the recipes repo locally.entrypoint.sh
: Define a crontab job to run every "X" minutes (or hours, or maybe once a day) togit fetch
andgit pull -r
the recipes local repo.Any thoughts on this? Do you agree?
The text was updated successfully, but these errors were encountered: