Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support templating in variables #20

Open
rylev opened this issue Apr 16, 2024 · 1 comment
Open

Support templating in variables #20

rylev opened this issue Apr 16, 2024 · 1 comment

Comments

@rylev
Copy link
Collaborator

rylev commented Apr 16, 2024

Variable support was added in #19, but templating is not supported. To do this, we should use spin-expressions (which is luckily already a dependency of spin-test-virt). Unfortunately, however, resolving a key can only be done asynchronously. This method is async because of variable providers being async. However, we won't be using variable providers, so in theory there can easily be a sync version of this method exposed that we can use.

@rylev
Copy link
Collaborator Author

rylev commented Apr 16, 2024

I have a fix for this based on fermyon/spin#2458.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant