Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect malformed configuration variable keys before up/deploy #1622

Closed
fibonacci1729 opened this issue Jun 27, 2023 · 1 comment · Fixed by #1623
Closed

Detect malformed configuration variable keys before up/deploy #1622

fibonacci1729 opened this issue Jun 27, 2023 · 1 comment · Fixed by #1623
Assignees
Labels

Comments

@fibonacci1729
Copy link
Contributor

fibonacci1729 commented Jun 27, 2023

The documentation for dynamic configuration variables specifies that Configuration keys may only contain lowercase letters and underscores between letters.

Currently, if i deploy an application with a malformed configuration key (e.g. LOG_LEVEL) my application will serve 500 and my logs will contain angry shouting about what the proper format is for keys.

I think it would be ideal if we somehow validate configuration keys pre-deploy/up or ask the doctor to do it.

@fibonacci1729 fibonacci1729 changed the title Detect malformed configuration variables before up/deploy Detect malformed configuration variable keys before up/deploy Jun 27, 2023
@itowlson
Copy link
Contributor

Yes, it looks like Spin validates the names only at run time (i.e. this happens locally not just in cloud). I am not sure why - I think this has come up before but can't remember the outcome. I'll take a look - thanks for flagging this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants