Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-CN translation #139

Closed
bitaller opened this issue Jan 25, 2021 · 3 comments
Closed

zh-CN translation #139

bitaller opened this issue Jan 25, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@bitaller
Copy link
Contributor

bitaller commented Jan 25, 2021

I'd like to contribute on zh-CN translation.

@fernandreu
Copy link
Owner

Hi bitaller, that would be awesome, thanks! Would you like me to create the baseline Strings.zh-CN.resx file that will need to be translated, or are you happy to do that yourself based on the instructions in here?

@fernandreu fernandreu added the enhancement New feature or request label Jan 25, 2021
@bitaller
Copy link
Contributor Author

bitaller commented Jan 26, 2021

I have created a pull request "Add zh-CN translation".
#140

btw, I haven't seen "language" setting on the menu of the editor.

@fernandreu
Copy link
Owner

That's the development build done with the translation added. It's available here: https://dev.azure.com/fernandreu-public/OfficeRibbonXEditor/_build/results?buildId=977&view=artifacts&pathAsName=false&type=publishedArtifacts

A few notes:

  • As I mentioned in Add zh-CN translation #140, I added your username to both the GitHub README (at the bottom) and the About dialog in the tool, with a link to your GitHub profile. If you want me to change that to a different username, link (or not mentioning anything at all), I'm happy to change it
  • I added an extra About.Translators entry for the Translators: header in the About dialog, in case you want to translate that as well (here)
  • There are a few items which are not supported for translation and will remain in English, either because it would be difficult or because I decided it would be best. These are the right-click menu entries of the editor and the legal text at the bottom of the About dialog

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants