Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove require('url') in favor of URL #53

Open
feross opened this issue Aug 7, 2019 · 2 comments · May be fixed by #55 or #78
Open

Remove require('url') in favor of URL #53

feross opened this issue Aug 7, 2019 · 2 comments · May be fixed by #55 or #78

Comments

@feross
Copy link
Owner

feross commented Aug 7, 2019

(Once we're ready to drop Node 8 support)

For: brave/brave-browser#5490

@gillesdemey
Copy link

It doesn't seem viable without support for relative URLs.

Relative URLs are currently used for the redirect logic and parsed from the Location header so we will have to wait for nodejs/node#28482 to land but it requires Node 12.x — which is likely a leap too far.

nodejs/node#12682
whatwg/url#421

@feross
Copy link
Owner Author

feross commented Oct 6, 2019

It's possible to do new URL('...', 'http://example.com') to parse a relative URL.

@Flet Flet linked a pull request Oct 29, 2019 that will close this issue
@LinusU LinusU linked a pull request Feb 6, 2022 that will close this issue
@LinusU LinusU linked a pull request Feb 6, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants