Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is this app deprecated by new libsass features? #7

Open
macgyver opened this issue Apr 1, 2016 · 6 comments
Open

is this app deprecated by new libsass features? #7

macgyver opened this issue Apr 1, 2016 · 6 comments

Comments

@macgyver
Copy link

macgyver commented Apr 1, 2016

Just a question, is this module still useful since sass/libsass#754?

@koenpunt
Copy link
Contributor

koenpunt commented Apr 2, 2016

Don't know actually, has it landed already in the node-sass release?

@macgyver
Copy link
Author

macgyver commented Apr 4, 2016

I'm not sure how to answer that question but I did find this https://github.com/sass/node-sass/blob/master/.gitmodules which implies to me that they just use whatever's on master?

@pascalduez
Copy link

 ./node_modules/.bin/node-sass -v
node-sass       3.8.0   (Wrapper)       [JavaScript]
libsass         3.3.6   (Sass Compiler) [C/C++]
@import 'normalize/normalize';

Result: Full file content included

@import 'normalize/normalize.css';

Result: @import url(normalize.css/normalize.css);

@christophervoigt
Copy link

christophervoigt commented Apr 27, 2018

.\node_modules\.bin\node-sass.cmd -v
node-sass       4.9.0   (Wrapper)       [JavaScript]
libsass         3.5.4   (Sass Compiler) [C/C++]
@import '~normalize.css/normalize';

Result: Full file content included, but:

DEPRECATION WARNING on line 3, column 8 of C:/chlorophyllkid/workspace/styleguide/src/base/base.scss:
Including .css files with @import is non-standard behaviour which will be removed in future versions of LibSass.
Use a custom importer to maintain this behaviour. Check your implementations documentation on how to create a custom importer.

So it's becoming a thing again to use this as a custom importer, right?

@christophervoigt
Copy link

@phazei
Copy link

phazei commented Jun 7, 2018

That deprecation warning was apparently a mistake that's going to be removed with libsass 3.6, but who knows when that'll release.
sass/libsass#2636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants