Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to delete none whitelisted domains in certificate update #85

Closed
ghost opened this issue Oct 26, 2022 · 2 comments · Fixed by #112
Closed

Option to delete none whitelisted domains in certificate update #85

ghost opened this issue Oct 26, 2022 · 2 comments · Fixed by #112
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Oct 26, 2022

In our usage of this library a domain which is in the whitelist might be removed from the whitelist later. We would appreciate it if the domain is then removed from the storage used by this library, too. This could be done in the certificate upate process.

In AUTOSSL.update_cert an error message is returned when a domain is not whitelisted. It would be nice to have an option that instead of returning an error message the domain is deleted from storage. That way a none whitlisted domain would not have to be checked every time the worker is running and there would not be unnecessary messages in the log.

@fffonion fffonion added the enhancement New feature or request label Nov 14, 2022
@fffonion
Copy link
Owner

@joergmoldenhauer That's a good idea. PRs are welcome! I will pick it up if no one is working on it : )

@DoobleD
Copy link
Contributor

DoobleD commented Jul 27, 2023

We're very much interested in that feature as well. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants