Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate the uses of ProxyMatcher when it is not needed #14

Open
fge opened this issue May 20, 2014 · 0 comments
Open

Eliminate the uses of ProxyMatcher when it is not needed #14

fge opened this issue May 20, 2014 · 0 comments

Comments

@fge
Copy link
Owner

fge commented May 20, 2014

Right now, the code for all rules in the generated parser class delegates rule "resolution" to a ProxyMatcher.

But this is not needed for many of them; let us call them the "terminal rules". Terminal in the sense that they do not have any delegates at all. A primary example of that is CharMatcher.

Example of what I mean here. In this case, well, a rule method in the parent class should not be generated at all, there's no point.

The problem is, how to detect that? At a first glance, this would mean adding a new method to Matcher determining whether the rule is indeed "terminal".

@fge fge added enhancement and removed question labels May 20, 2014
@fge fge added this to the 1.1.0 milestone Nov 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant