Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart plugin - When unchecking labels the next results will keep the same check/uncheck choices #409

Open
MLAuger opened this issue Apr 6, 2022 · 4 comments
Assignees
Labels
plugin-chart Issues related to chart plugin

Comments

@MLAuger
Copy link
Collaborator

MLAuger commented Apr 6, 2022

When you uncheck labels in one chart and you close it, the next chart that will open keeps the same check/uncheck choices.

This is not optimal, since it can send an erroneous message leaving the user believing that the previoulsy uncheck labels are not surveyed for the following stations. Moreover, considering you cannot see the uncheck labels until you click on the drop down menu.

Example:

  1. Uncheck 7Be for the Whitehorse station
    image

  2. Close the Whitehorse chart

  3. Click on the Winnipeg station and the 7Be is not displayed. Opening the label drop down menu shows that the 7Be is already unchecked
    image

Could it be possible that these options be reset when closing a chart?

@jolevesq jolevesq added the plugin-chart Issues related to chart plugin label Apr 6, 2022
@jolevesq
Copy link
Contributor

jolevesq commented Apr 6, 2022

@MLAuger if I remember it was a request to keep the chart state. This reset can be done no problem.

@MLAuger
Copy link
Collaborator Author

MLAuger commented Apr 6, 2022

I don't see why I could've requested this... I remember there was a problem with the labels disappearing from one chart to the other when unchecked. Maybe that's why it ended up that way.

Anyway, I don't see any problem with reseting the labels at every click. I think it's better. Do you?

@jolevesq
Copy link
Contributor

jolevesq commented Apr 6, 2022

It is a preference I think. We can reset it and revise if there is a request

@MLAuger
Copy link
Collaborator Author

MLAuger commented Apr 6, 2022

That's fine with me.

@Pewillia Pewillia self-assigned this May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin-chart Issues related to chart plugin
Projects
None yet
Development

No branches or pull requests

3 participants